Mixin method remap: fix desc being dropped & support wildcards#164
Open
Moulberry wants to merge 14 commits intoFabricMC:masterfrom
Open
Mixin method remap: fix desc being dropped & support wildcards#164Moulberry wants to merge 14 commits intoFabricMC:masterfrom
Moulberry wants to merge 14 commits intoFabricMC:masterfrom
Conversation
LlamaLad7
suggested changes
Apr 26, 2026
Moulberry
commented
Apr 26, 2026
…ble to parse quantifier
…ier by the caller
desyd3780-cpu
approved these changes
Apr 30, 2026
desyd3780-cpu
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed descriptor being dropped when input had descriptor
Descriptor should be used in output if and only if either:
Added support for resolving multiple targets when using wildcard
See remapSeparateRemappedName test for example
After the rewrite commit, this addresses a lot of additional problems and edge cases brought up by LlamaLad7 on discord