Updates to work with CUDA >=12.9#40
Conversation
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
|
Looks good to me! @mhrywniak could you have a second look? |
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
|
Generally replacing the include line is the correct fix, i.e. I think the other I'm only listing the ones in the A small correction: The deprecation happened in CUDA 12.9 already, , see also https://docs.nvidia.com/cuda/archive/12.9.1/cuda-toolkit-release-notes/index.html#id3 I think this just hasn't surfaced before as we never ran the tutorial with CUDA > 12.6 (afaict from So I'd request the following additional changes:
|
|
I think, @prateekchawla168 is making individual merge request per directory :). |
|
I think it's better to have it consolidated, would ask to combine those into one since it's the same structural change and feedback would need to be duplicated in all the reviews. |
updates to work with cuda 12.9+
changes to accomodate for cuda 12.9+
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
|
Quick summary of changes:
The repo now works with CUDA 13. |
|
Thanks! |
adel-dabah
left a comment
There was a problem hiding this comment.
All changes make sense. -I$(CUDA_HOME)/include isn’t needed in most Makefiles, but it doesn’t hurt either. Everything looks good to me!
Updated files:
Across all folders -> .master, solutions (/advanced), tasks
Changes:
$(CUDA_HOME)/includeto NVCC flags (For thenvtx3/nvToolsExt.hheader)nvToolsExtfrom NVCC_LDFLAGS (no longer supported in CUDA 13.x) and NVCC_FLAGSjacobi.cuto reflect the new library structure