feat: add deferred failures and batch image review UI#374
Open
FRSgit wants to merge 3 commits into
Open
Conversation
All cy.matchImage() calls no longer fail immediately when the diff threshold is exceeded. Instead, failures are accumulated and reported as a single error at the end of the spec (opt-in via pluginVisualRegressionDeferFailures env var). A persistent floating action button (plugin logo) is injected into the Cypress runner and shows a badge with the count of pending diffs. Clicking it opens: - an informational modal when there are no diffs - a fullscreen carousel for reviewing all changed images when diffs exist The carousel supports Replace image / Skip this change / keyboard navigation and shows a success animation on the FAB after approvals. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erage - Run prettier on commands.ts and support.ts (fix lint CI failure) - Add c8 ignore on browser-only template helpers in support.ts - Add unit tests for recordPendingDiffTask, getPendingDiffsTask, and clearPendingDiffsTask to bring function coverage back above 90% Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ew-ui # Conflicts: # packages/cypress-plugin-visual-regression-diff/src/commands.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All cy.matchImage() calls no longer fail immediately when the diff threshold is exceeded. Instead, failures are accumulated and reported as a single error at the end of the spec (opt-in via pluginVisualRegressionDeferFailures env var).
A persistent floating action button (plugin logo) is injected into the Cypress runner and shows a badge with the count of pending diffs. Clicking it opens:
The carousel supports Replace image / Skip this change / keyboard navigation and shows a success animation on the FAB after approvals.