fix: explicitly define more nullable types - #39
Open
zrckr wants to merge 3 commits into
Open
Conversation
Member
|
If you're at least 90% sure your manual checks for creating those unit tests are correct, I'm perfectly fine with merging it. However, you've shown interest in producing unit tests directly from stripped game libraries. So I'll let you choose what's more appealing to you - wouldn't want to take away fun from you :) |
Krzyhau
approved these changes
Jul 27, 2026
Contributor
Author
|
I used the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fields were already marked as nullable in b019045 and 97c5531. This PR marks additional fields as nullable and adds default values for the fields, in accordance with the class definitions in the original game. This also adds the corresponding tests.
I’m not entirely sure this will completely eliminate ALL footguns for FEZEditor or HAT mod loader, but at least it makes the contract more explicit, given that the game predates nullable-reference annotations.
If there’s a better way to resolve the root discrepancy, feel free to reject this PR.