[Feat.] backup script can now expand the files.tar.gz backup in a remote server - #156
Open
cgbautista wants to merge 4 commits into
Open
[Feat.] backup script can now expand the files.tar.gz backup in a remote server#156cgbautista wants to merge 4 commits into
cgbautista wants to merge 4 commits into
Conversation
remote server.
Added a new flag to be able to use the same name for that file each
time, so only a single backup has to be managed (as the new backup
system is used instead)
idelcano
reviewed
Dec 22, 2025
| fi | ||
| log "expand files backup into ${DB_REMOTE_DEST_SERVER}..." | ||
|
|
||
| ssh ${DB_REMOTE_DEST_SERVER} "${remote_expand_script} -i \"${files_path}\" -o \"${dump_remote_dest_folder}\" 2>&1 | tee -a \"${remote_log}\" " |
Contributor
There was a problem hiding this comment.
hi @cgbautista the script is good for me, but looking in depth the PR with codex, it suggest me a addition here:
Small suggestion: let’s add set -o pipefail; before the pipeline in the remote SSH command, so the overall command fails if remote_expand_script fails (not just tee).
From:
ssh ${DB_REMOTE_DEST_SERVER} "${remote_expand_script} -i "${files_path}" -o "${dump_remote_dest_folder}" 2>&1 | tee -a "${remote_log}" "
To:
ssh ${DB_REMOTE_DEST_SERVER} "set -o pipefail; ${remote_expand_script} -i "${files_path}" -o "${dump_remote_dest_folder}" 2>&1 | tee -a "${remote_log}" "
what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new flag to be able to use the same name for that file each time, so only a single backup has to be managed (as the new backup system is used instead)