Onboarding: capture accounting system name for Other

[KJ21-ENG]

Explanation of Change

Adds an optional accounting-software name input when an onboarding user selects Other. The name is stored separately from the existing userReportedIntegration: 'other' value, trimmed, and sent as userReportedIntegrationName with CreateWorkspace and CompleteGuidedSetup only when Connections remains enabled and the name is non-empty.

The accounting screen reveals the input without automatically focusing it or forcing the options viewport to scroll. The option grid remains stationary, the top row stays visible, and the responsive card layout does not shift when the content becomes scrollable.

Fixed Issues

$ #93290
PROPOSAL: #93290 (comment)

Tests

1. Verify that no errors appear in the JS console.
2. Sign in with a new account and start the onboarding flow for managing a team.
3. Continue to the accounting-software step and select Other.
4. Verify the Your accounting software input appears below the option grid without automatically receiving focus, moving the cards, clipping the first row, or being hidden behind the fixed Continue footer.
5. Enter Acme Books and press Continue.
6. On Interested Features, leave Connections enabled and press Continue.
7. Verify the CreateWorkspace and CompleteGuidedSetup requests keep userReportedIntegration: 'other' and include userReportedIntegrationName: 'Acme Books'.
8. Repeat the flow, enter a custom name, then select a supported integration. Verify the input is hidden and neither request includes userReportedIntegrationName.
9. Repeat with Other and a blank/whitespace-only input. Verify onboarding can continue and neither request includes userReportedIntegrationName.
10. Repeat steps 3-9 on a narrow/mobile viewport and a wide/desktop viewport. Verify selecting Other does not jump or force-scroll the options viewport, the first row remains visible, the input remains reachable above the footer, and the option cards retain their widths and spacing. On a genuinely constrained viewport, verify the screen can still be scrolled manually to the input.

• Verify that no errors appear in the JS console

Offline tests

1. Open the accounting-software onboarding step, then go offline.
2. Select Other, enter Acme Books, and press Continue.
3. Verify the Interested Features step opens with Connections enabled and the input remains restored when navigating back.
4. Return to Interested Features and verify Continue is disabled while offline.
5. Reconnect, finish onboarding, and verify the onboarding requests send userReportedIntegration: 'other' with userReportedIntegrationName: 'Acme Books'.
6. Verify that no errors appear in the JS console.

QA Steps

1. Sign in with a new account and start the onboarding flow for managing a team.
2. On the accounting-software step, select Other and verify the Your accounting software input is fully visible above the footer.
3. Enter Acme Books, continue with Connections enabled, and complete onboarding.
4. Verify both onboarding requests include userReportedIntegration: 'other' and userReportedIntegrationName: 'Acme Books'.
5. Repeat with a supported integration, None, and a blank Other input; verify userReportedIntegrationName is omitted in all three cases.
6. Repeat on narrow and wide layouts and verify selecting Other does not automatically focus the input, jump or force-scroll the options viewport, clip the first row, change the card spacing, or hide the input behind the footer. On a genuinely constrained viewport, verify the input remains reachable through manual scrolling.
7. Verify that no errors appear in the JS console.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified that any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

1784110647273871-compressed.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[KJ21-ENG]

FYI :- Failing jest tests are unrelated to this PR. Thanks!

[melvin-bot]

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62a15bd735

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".