[No QA] Log auth session result type on non-success native SAML sign-in#96156
[No QA] Log auth session result type on non-success native SAML sign-in#96156MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
|
🤖 All checks are now green — no fix was needed. When you pinged me, the only red check was Final status
Since the change is a single diagnostic |
|
🤖 Re-checked — there are no failing checks to fix.
No code changes are warranted: the PR adds a single diagnostic |
Explanation of Change
Native SAML SSO sign-in can leave Android users stuck on the loading screen / bouncing back to the sign-in page (a login "loop"), and today the app gives us almost nothing to debug it with.
This PR adds a single
Log.hmmmon that branch recordingresponse.type(cancel,dismiss,locked, etc.). That lets us tell apart, from logs alone, "the browser session never returned a success result" from "it returned but carried no token".Fixed Issues
related to #86705
Tests
None.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari