Workspace rate list display for auto-generated rates by thelullabyy · Pull Request #96149 · Expensify/App

thelullabyy · 2026-07-14T23:53:41Z

Explanation of Change

Fixed Issues

$ #95280
PROPOSAL: NA

Tests

Setup:

Open a paid workspace that has Distance rates enabled (Workspace > More features > toggle Distance rates if needed).
Go to Workspaces > [workspace] > Distance rates. Make sure at least 2 rates exist (add one via Add rate if needed) so you can compare a government rate against a normal one.

Seed a mock government rate:
With the Distance rates page open, turn off internet, run this in the browser console:

const policy = await window.policy;
const customUnit = Object.values(policy.customUnits).find((u) => u.name === 'Distance');
const rateID = Object.keys(customUnit.rates).at(0);
await window.Onyx.merge(`policy_${policy.id}`, {
    customUnits: {
        [customUnit.customUnitID]: {
            rates: {
                [rateID]: {
                    rate: 72.5,
                    startDate: '2026-01-01',
                    endDate: '2026-12-31',
                    attributes: {
                        governmentRate: {sourceRateID: 'US_2026-01-01', rate: 72.5, startDate: '2026-01-01', endDate: '2026-12-31'},
                    },
                },
            },
        },
    },
});

Verify that:

Icon displays for an unmodified government rate

In the rates table, the seeded rate shows a small lightning-bolt icon next to the amount in the Rate column.
Hover the icon: tooltip reads "This rate is auto-generated."
Other rates show no icon.

Narrow layout

Shrink the browser window to mobile width (or test on the mobile web layout).
The bolt icon appears next to the "rate • date" line under the rate name, with the same tooltip behavior on hover.

Icon hides when the rate value is edited

Open the seeded rate > Rate, change the amount (e.g. 0.725 → 0.99), save.
Back in the list, the bolt icon is gone.

Icon restores when the value is edited back

Change the amount back to exactly 0.725 and save.
The bolt icon reappears.

Same hide/restore behavior for dates

Edit the Start date (e.g. to 2026-02-01) → icon hides. Restore to 2026-01-01 → icon returns.
Edit the End date (e.g. to 2026-11-30) → icon hides. Restore to 2026-12-31 → icon returns.

Open-ended rate matching

Re-run the seed snippet but with endDate: null on the rate and no endDate key inside governmentRate → icon shows (omitted on both sides counts as a match).
Then set an end date on the rate via the UI → icon hides (omitted on only one side is not a match).

Things that should NOT affect the icon

Rename the rate → icon stays (name isn't part of the snapshot).
Toggle the rate off/on via the switch → icon stays; only the status badge changes.
Sorting by any column and searching via Find rate work as before, with the icon following its row.

Regression pass on a normal workspace

Open a workspace whose rates were never seeded: the list renders exactly as before, no icons, no layout shift in the Rate column.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-14.at.19.07.55.mov

melvin-bot · 2026-07-14T23:53:45Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-07-15T00:09:06Z

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thelullabyy · 2026-07-15T00:09:28Z

@neil-marcellini Could you please help trigger the translation workflow? Thanks

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5295e3c468

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-15T00:15:15Z

+        return false;
+    }
+
+    return rate.rate === governmentRate.rate && (rate.startDate ?? undefined) === governmentRate.startDate && (rate.endDate ?? undefined) === governmentRate.endDate;


Compare restored rates with numeric tolerance

For government rates whose displayed value does not round-trip exactly through the edit form, this exact equality keeps the auto-generated icon hidden even after the user restores the original value. The existing submit path stores Number(values.rate) * 100, so restoring a snapshot rate like 29 cents from 0.29 produces 28.999999999999996 in optimistic Onyx state; while offline (and potentially until the server normalizes it) isGovernmentRateUnmodified returns false even though the UI value matches the snapshot.

Useful? React with 👍 / 👎.

@thelullabyy Good catch here. We should probably handle potential floating-point rounding differences when comparing rates

cretadn22 · 2026-07-15T02:10:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

cretadn22 · 2026-07-15T02:30:50Z

+ */
+function isGovernmentRateUnmodified(rate: Rate): boolean {
+    const governmentRate = rate.attributes?.governmentRate;
+    if (!governmentRate) {


A smaller edge worth a thought while touching that line: if a malformed governmentRate snapshot exists but has no rate field and the rate's own fields are also unset, undefined === undefined on all three comparisons returns true and shows the icon. Guarding with governmentRate.rate === undefined → false would make the helper robust, but I wouldn't block on it.

cretadn22 · 2026-07-15T02:31:38Z

+        return false;
+    }
+
+    return rate.rate === governmentRate.rate && (rate.startDate ?? undefined) === governmentRate.startDate && (rate.endDate ?? undefined) === governmentRate.endDate;


@thelullabyy Good catch here. We should probably handle potential floating-point rounding differences when comparing rates

cretadn22 · 2026-07-15T02:33:37Z

@thelullabyy Mind taking a look at the failing typescript checks and Jest Unit Tests? Also, please upload the complete test videos when you get a chance

thelullabyy · 2026-07-15T10:08:15Z

The test failed due to missing copies. I requested it here #96149 (comment)

joekaufmanexpensify

Good for product.

feat: Workspace rate list display for auto-generated rates

5295e3c

melvin-bot Bot assigned thelullabyy Jul 14, 2026

thelullabyy marked this pull request as ready for review July 15, 2026 00:09

thelullabyy requested review from a team as code owners July 15, 2026 00:09

melvin-bot Bot requested review from cretadn22 and joekaufmanexpensify and removed request for a team July 15, 2026 00:09

melvin-bot Bot removed the request for review from a team July 15, 2026 00:09

chatgpt-codex-connector Bot reviewed Jul 15, 2026

View reviewed changes

cretadn22 reviewed Jul 15, 2026

View reviewed changes

joekaufmanexpensify approved these changes Jul 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Workspace rate list display for auto-generated rates#96149

Workspace rate list display for auto-generated rates#96149
thelullabyy wants to merge 1 commit into
Expensify:mainfrom
thelullabyy:fix/95280

thelullabyy commented Jul 14, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jul 14, 2026

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

thelullabyy commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 15, 2026

Uh oh!

cretadn22 Jul 15, 2026

Uh oh!

cretadn22 commented Jul 15, 2026

Uh oh!

cretadn22 Jul 15, 2026

Uh oh!

cretadn22 Jul 15, 2026

Uh oh!

cretadn22 commented Jul 15, 2026

Uh oh!

thelullabyy commented Jul 15, 2026

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

thelullabyy commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 14, 2026

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

thelullabyy commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 commented Jul 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

cretadn22 Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 commented Jul 15, 2026

Uh oh!

thelullabyy commented Jul 15, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thelullabyy commented Jul 14, 2026 •

edited

Loading