[No QA] Auto-file staging retest request for cherry-picked blocker fixes#96103
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9a96ce8c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
|
gonna hold off on merging/CPing this to staging until the next time I need to run a CP myself so I can test this out. |
|
Actually, this should hit staging after this next deploy, so I think we should be good to just merge. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.35-1 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and they do not require any updates to Expensify's help site files under Why: This is an internal CI/deploy-workflow change. It adds a script ( Since no changes are needed, I did not create a draft help site PR — there is nothing to link. @jasperhuangg, please confirm you agree no help site updates are needed here. If you believe a customer-facing doc is affected, let me know which behavior and I'll draft the update. |
Explanation of Change
When a deploy-blocker fix is cherry-picked to staging, the deployer currently files a Slack
#retestsrequest by hand. This does it automatically: a new deploy job fires on a staging cherry-pick (once all platforms land) when the cherry-picked PR is on the currentStagingDeployCashchecklist and links a deploy-blocker issue on it, then POSTs the retest request to the Slack webhook.The webhook URL is loaded from 1Password (
Repository-Secrets/SLACK_RETEST_WEBHOOKin theMobile-Deploy-CIvault), not the code.How it works
StagingDeployCashchecklist and links a deploy-blocker issue on it.#retestsworkflow.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/574358
PROPOSAL:
Tests
This is a deploy-workflow change with no app-facing UI. It only runs inside the staging deploy for a cherry-pick, so it can't be exercised in the local dev environment. Logic is covered by unit tests:
npx jest tests/unit/createRetestRequestForCPTest.ts.Offline tests
N/A, this runs in CI during a deploy, there is no offline client behavior.
QA Steps
N/A. This only runs in the staging deploy workflow when a deploy-blocker fix is cherry-picked to staging, so it can't be triggered on demand by QA. Title includes
[No QA].PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A, this is a CI/deploy workflow change with no app UI.
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A