Docs updates for E/A#90029 Update Spend page filter popover UI docs#91759
Docs updates for E/A#90029 Update Spend page filter popover UI docs#91759MelvinBot wants to merge 1 commit into
Conversation
Reflects the changes from E/A#90029 which updates the advanced filters button to open a popover on web and a full-screen view on mobile, with Apply and Reset buttons. Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR updates the "Getting Started with the Spend Page" article to document the new advanced filter popover UI introduced in PR #90029. It adds platform-specific (Web/Mobile) step-by-step instructions, updates keywords, improves a heading to be task-based, and adds a cross-link to the search operators article. The changes are well-scoped and generally align with governance standards, with a few items to address. Scores Summary
Key FindingsPositive aspects:
Items to address:
Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6acb03f406
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 2. Click the **Filters** button. | ||
| 3. A popover opens showing available filters. | ||
| 4. Hover over a filter to see its options. |
There was a problem hiding this comment.
Describe the desktop Filters button as a page
On desktop/web, clicking the Filters button does not open a popover that users can hover through; SearchAdvancedFiltersButton navigates to ROUTES.SEARCH_ADVANCED_FILTERS, which renders the SearchAdvancedFiltersPage right-modal/list flow. The popover components are used for already-applied filter chips in the filters bar, so these steps send users looking for a hover popover that never appears when starting from the Filters button.
Useful? React with 👍 / 👎.
| 5. Set a value and tap **Apply** to confirm the selection. | ||
| 6. Tap **Apply** again on the filter list to apply your filters. | ||
| 7. To clear active filters, tap **Reset** at the bottom of the filter list. |
There was a problem hiding this comment.
Use the actual mobile filter button labels
In the mobile/narrow advanced filter flow, filter detail pages save selections with Save, then the filter list applies them with View results, and reset is exposed as the Reset filters header link when filters are active. There is no second Apply button or bottom Reset on the filter list, so users following these steps will not find the documented controls.
Useful? React with 👍 / 👎.
| 1. Go to the **Spend** page. | ||
| 2. Click the **Filters** button. | ||
| 3. A popover opens showing available filters. | ||
| 4. Hover over a filter to see its options. |
There was a problem hiding this comment.
Step formatting / deterministic writing: "Hover over a filter to see its options" is vague. Consider specifying which filter types support hover behavior, or merge this with step 5 since the next steps already describe each filter type individually.
| 3. The advanced filters open in a full-screen view. | ||
| 4. Tap any filter to see its options. | ||
| 5. Set a value and tap **Apply** to confirm the selection. | ||
| 6. Tap **Apply** again on the filter list to apply your filters. |
There was a problem hiding this comment.
Step clarity: Steps 5 and 6 both say "tap Apply" but for different purposes. This can confuse users. Consider making step 6 more explicit, e.g., "Tap Apply at the top of the filter list to confirm all selected filters and return to the filtered results."
Summary
Changes
docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md: Updated the "How to Use Filters" section with platform-specific instructions for the new advanced filter UI, added cross-link to search operators article, and updated heading to be task-based per authoring guidelines.@bernhardoj, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.