Restore slight fade-in for centered alert modals on web#91702
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-27.at.10.46.26.PM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-05-27.at.10.42.47.PM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-05-26.155208.mp4 |
|
@ChavdaSachin Are you assigned to review this feature? |
|
Feels great to me, send it 🚀 |
No one is assigned to the feature, |
@ChavdaSachin You were assigned after me. @Julesssss, who will review this PR? |
|
Feels good to me too! |
We will stick with @ChavdaSachin as they have completed the checklist and captures |
|
@ChavdaSachin could you please continue with the review, thank you |
|
Test for QA:
|
Julesssss
left a comment
There was a problem hiding this comment.
Added test cases to description, thanks!
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.89-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site updates required. This PR is a web-only animation timing tweak:
There are no changes to features, button labels, tab names, settings, workflows, or any user-facing behavior that's documented in No draft docs PR was created. |
Explanation of Change
PR #90212 ("Tune web modal, dropdown and RHP animations") reduced all web modal open/close timings to 1ms via platform-keyed
DEFAULT_IN/DEFAULT_OUTconstants. @shawnborton noted in review feedback that centered alert modals felt too abrupt and requested a slight fade-in.This PR adds per-type timing overrides for centered modal variants on web only:
CONST.MODAL.ANIMATION_TIMING.CENTERED_DURATION_IN_WEB: 120andCENTERED_DURATION_OUT_WEB: 80are added alongside the existingRHP_DURATION_*_WEBconstants.src/components/Modal/index.tsx(web entry point) detects whentypeisCONFIRM,CENTERED,CENTERED_UNSWIPEABLE,CENTERED_SMALL, orCENTERED_SWIPEABLE_TO_RIGHTand applies these timings as defaults — caller-providedanimationInTiming/animationOutTimingstill take precedence.fadeIn/fadeOutanimations are reused.index.tsxentry point is not used on those platforms.Fixed Issues
$ #90146
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari