feat(lfg): fold compounding into the skill and bring it to parity#879
feat(lfg): fold compounding into the skill and bring it to parity#879kieranklaassen wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46b93a0b09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
46b93a0 to
999f526
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 999f526bdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…food, compound-out Re-targets PR #879 onto the root-native repo layout (#967 moved the skill to skills/lfg/ and the plugin went skills-only). The original PR's cloud-only .claude/workflows/lfg.js is dropped: it isn't a distributable plugin artifact, re-implemented the whole pipeline as a second surface that had already drifted from the skill, and invoked top-level researcher agents that no longer exist (they're now references/agents inside ce-plan). Instead, the compounding idea is expressed inside the linear skill itself, with no harness dependency: - compound-in: planning already fans out ce-plan's institutional-recall researchers (learnings, repo conventions, git history, best practices) -- made explicit on step 1, no duplicate research step. - compound-out: a new ce-compound mode:headless step captures the durable, non-obvious learning into docs/solutions/ so the next run starts ahead; non-blocking (Documentation skipped is success), shipped via the commit step. Also brings the warranted parity additions from #879 onto main's step structure: - Input resolution: accept a Riffrec bundle, video/audio, or screenshots and analyze via ce-riffrec-feedback-analysis before planning. - Reproduce-before-fix for bug fixes, with synthetic/anonymized state. - A Dogfood step inlining ce-dogfood's diff-scoped behavior (renamed from ce-dogfood-beta; still disable-model-invocation, so inlined not invoked). - A fixed PR-body template for feedback-sourced runs. Dropped the ce-demo-reel demo-capture instruction (no such skill on main). Co-Authored-By: Kieran Klaassen <kieranklaassen@gmail.com>
999f526 to
a97c58f
Compare
Context: rebased and re-scoped onto the current
|
…eamble Step 1 now passes 'the resolved task'; no body step references $ARGUMENTS, so the closing 'use the resolved task wherever a step passes $ARGUMENTS' pointed at nothing. Replace it with a direct hand-off to step 1 and the step-10 PR body.
…instruction-file edit Two gaps surfaced by a gate-branch eval of the skill: - Step 7 (ce-test-browser) had no skip clause, so a docs-only or cli/api/library/ios-only change still invoked it. Add a skip for diffs that touch no web-ui surface, mirroring the docs-only skips on steps 3 and 8. - Step 9's compound-out left it unspecified that ce-compound in headless mode can also edit an instruction file (AGENTS.md/CONCEPTS.md) for docs/solutions discoverability; that edit rides into the run's PR via step 10. State it so it reads as expected output, not stray changes to revert.
Validation: gate-branch eval of the lfg skillTo raise confidence in the behavioral changes (input resolution, dogfood step, compound-out, and the no-remote shipping precondition), I ran an agent-owned eval focused on the gate branches, not just the happy path. Method. A decision-trace eval rather than a live pipeline run — actually executing Cases (all PASS):
Net findings → fixed in this PR:
Honest scope. This verifies the new gate logic is correct — it is not an old-vs-new improvement comparison, since the prior skill at this path didn't have these branches. One methodology caveat: two baseline agents read the real
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4946928501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- lfg input resolution: extract-only for Riffrec/video/audio; do not continue into ce-brainstorm's interactive path, so autonomous runs don't block - lfg feedback PR template: make narration block-quote and before-frames conditional on a transcript; screenshot-only runs describe what's shown, no invented quote - docs sync: README, docs/skills/lfg.md, and the skill catalog now describe the widened inputs (description/Riffrec/video/screenshots) and the dogfood + compound-out stages
Summary
/lfgwas linear and amnesiac: every run started from zero and ended teaching the next one nothing. This PR folds the compounding loop directly into the linear/lfgskill and brings the skill up to parity on the capabilities it was missing — entirely inside the skill, with no harness-specific dependency.What's new
Compounding, in the skill:
ce-plan's institutional-recall researchers (prior learnings indocs/solutions/, repo conventions, git history, best practices), so a run starts from accumulated knowledge instead of a blank slate. Made explicit on step 1; no duplicate research step.ce-compound mode:headlessstep captures the durable, non-obvious learning from the run intodocs/solutions/so the next run's planning starts ahead. Non-blocking (Documentation skippedis a success); the learning doc ships via the commit step.Skill parity — the capabilities
/lfgwas missing:ce-dogfood's diff-scoped behavior — it'sdisable-model-invocation, so it's inlined, not invoked)./lfganalyzes it viace-riffrec-feedback-analysisbefore planning.Changed since the original PR
.claude/workflows/lfg.js(840 lines).ce-simplify-code,ce-work mode:return-to-caller, theartifact_contractreadiness gate, and the no-remote shipping precondition).ce-dogfood-beta→ce-dogfood(promoted to stable in feat(ce-dogfood): promote from beta to stable #1022).ce-demo-reeldemo-capture instruction — no such skill exists on main.Testing
bun test(1687 pass) andbun run release:validatepass. The LLM-behavior changes to the skill are not exercised bybun test; validate those via the skill-creator eval workflow or a fresh session, per the repo's plugin-caching rule.