GH-1334 Update settings comment and default permission check#1334
Open
GH-1334 Update settings comment and default permission check#1334
Conversation
CitralFlo
requested review from
ChudziudgiToJa,
Jakubk15,
Rollczi,
igoyek,
imDMK and
vLuckyyy
CitralFlo
added
📝 documentation
CitralFlo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the home limit logic to use a configurable default value (eternalcore.home.default) instead of a hardcoded zero when no specific permission nodes match. It also updates the configuration documentation to better explain how permission-based limits and fallbacks are applied. A suggestion was made to clarify the wording in the configuration comments regarding the default permission node to avoid ambiguity.
eternalcore-core/src/main/java/com/eternalcode/core/feature/home/HomesConfig.java
Show resolved
Hide resolved
vLuckyyy
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create better documentation for max homes list. Add default permission that is optional for max homes limit.
Fixes # (issue)
No default permission available - discord support 09.04.2026
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested default permission, vip and premium with LuckPerms.
Checklist: