[gui] Fix statistics table coloring - #4981
Open
gulyasgergely902 wants to merge 1 commit into
Open
Conversation
barnabasdomozi
left a comment
barnabasdomozi
left a comment
Collaborator
There was a problem hiding this comment.
Is the components/Statistics/style.scss file still used by other components or can be deleted?
gulyasgergely902
force-pushed
the
fix-guideline-statistics-coloring
branch
from
July 21, 2026 13:49
e911156 to
29efaf4
Compare
gulyasgergely902
force-pushed
the
fix-guideline-statistics-coloring
branch
2 times, most recently
from
July 22, 2026 08:11
e837307 to
38f1905
Compare
dkrupp
requested changes
Aug 4, 2026
dkrupp
left a comment
dkrupp
left a comment
Member
There was a problem hiding this comment.
Can you please add the same coloring ot the checker coverage table too?
that table is generated very similarly to the guidelinestatistics table.
A lot of copy paste code unfortunately.
gulyasgergely902
force-pushed
the
fix-guideline-statistics-coloring
branch
2 times, most recently
from
August 5, 2026 07:52
78b17ae to
50c105b
Compare
This change fixes the coloring issues of the statistics tables. All tables are now colored as it was before the update without the shifted "Total" row. The guideline statistics table highlights the rows only with outstanding reports greater than 0.
gulyasgergely902
force-pushed
the
fix-guideline-statistics-coloring
branch
from
August 5, 2026 07:53
50c105b to
7f0a049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the coloring issues of the statistics tables. All tables are now colored as it was before the update without the shifted "Total" row. The guideline statistics table highlights the rows only with outstanding reports greater than 0.