Change all pre-endpoint product/version failures to ProductNotFoundError#4887
Open
Discookie wants to merge 1 commit into
Open
Change all pre-endpoint product/version failures to ProductNotFoundError#4887Discookie wants to merge 1 commit into
Discookie wants to merge 1 commit into
Conversation
bruntib
requested changes
Jun 17, 2026
| f"nonexistent product: '{product_endpoint}'." | ||
| LOG.error(error_msg) | ||
| raise ValueError(error_msg) | ||
| LOG.debug(error_msg) |
Contributor
There was a problem hiding this comment.
The exception handler prints this message to the debug log already. I think, this could be removed.
| @@ -501,9 +501,9 @@ def do_POST(self): | |||
| else: | |||
| LOG.debug("This API endpoint does not exist.") | |||
Contributor
There was a problem hiding this comment.
The exception handler prints this message to the debug log already. I think, this could be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a couple unnecessary stack traces from the server console.