[ci] Add fixup! commit check for pull requests#4878
Conversation
f934428 to
2d6fb6a
Compare
The fixup! commit check workflow will check any commits on a given pull request and fail if there is any. This way it is enforced to squash all fixup! commits which were made with the argument '--fixup=...' when committing.
4af9b70 to
52a7867
Compare
|
Thanks for the attention to detail and for being conscious of code quality in this regard as well, @gulyasgergely902. |
|
So basically, this workflow is for the specific case which the new git workflow is describing: After the developer opened the PR for the changes made and the reviewer found any bugs/mistakes/etc., the developer should fix those in a fixup! commit made with --fixup=. This makes checking what changes were pushed in a response to the requests easier. After everything was fixed and the reviewer is happy with the results, asks the developer to squash the changes with --autosquash in a rebase command. This makes every fixup squashed to the right commit where it belongs. This automation guards the git tree of an accidental merge with fixup commits still present. |
The fixup! commit check workflow will check any commits on a given pull request and fail if there is any. This way it is enforced to squash all fixup! commits which were made with the argument '--fixup=...' when committing.