Skip to content

feat(notification): notification read API 구성 #28 - #66

Open
wlyoon921 wants to merge 2 commits into
developfrom
feat/28-notification-read-api
Open

feat(notification): notification read API 구성 #28#66
wlyoon921 wants to merge 2 commits into
developfrom
feat/28-notification-read-api

Conversation

@wlyoon921

Copy link
Copy Markdown

Summary

공지, QnA, 전형요강 조회 REST API와 JPA 조회 adapter를 구성했습니다.
명세 기준의 목록/상세 응답 DTO와 mapper를 추가했습니다.
notification adapter-in/out Bazel 의존성을 정리했습니다.

Related Issue

Related to #28

Scope

In scope:

  • NotificationController
  • 공지 목록/상세 조회 DTO
  • QnA 목록/상세 조회 DTO
  • 전형요강 조회 DTO
  • ApiResponse 및 exception handler
  • notification JPA entity/repository/adapter
  • adapter-in/out Bazel 의존성

Out of scope:

  • 공지 등록/수정/삭제
  • QnA 등록/수정/삭제
  • 전형요강 등록/수정/삭제
  • 파일 업로드/다운로드 API
  • admin API

Implementation

다음 조회 API를 구현했습니다.

  • GET /api/notification/v11/notifications/notification
  • GET /api/notification/v11/notifications/notification/{id}
  • GET /api/notification/v11/notifications/qna
  • GET /api/notification/v11/notifications/qna/{id}
  • GET /api/notification/v11/notifications/guideline

Controller는 NotificationPort를 호출하고 mapper를 통해 명세 응답으로 변환합니다.
조회 데이터는 JPA repository adapter를 통해 MySQL에서 가져오도록 구성했습니다.
Not found 상황은 NotificationNotFoundException을 통해 공통 error response로 변환합니다.

Testing

  • Unit test code: 후속 테스트 PR에서 추가
  • Integration tests: 후속 이슈에서 보완 필요
  • Manual verification: 후속 PR에서 build/test 수행 예정

Deployment Notes

Feature flag: 없음
Migration required: 예, notification DB schema 필요
Rollout considerations:

  • admin 등록/수정/삭제 API가 병합되기 전에는 테스트용 seed data가 필요합니다.
  • 전형요강 첨부 파일 자체는 configuration/document 서비스 연동이 필요합니다.

Checklist

  • Matches product/tech requirements
  • Backward compatibility considered
  • API schema compatibility considered
  • API success flow verified in a running environment
  • Real persistence adapter connected

@wlyoon921
wlyoon921 requested review from kusuri12-09 and tlgms July 30, 2026 11:34
@wlyoon921 wlyoon921 self-assigned this Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ready-for-review
🚫 Excluded labels (none allowed) (2)
  • wip
  • do-not-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6ff1c1de-af40-4d55-8adf-046998f29311

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wlyoon921 wlyoon921 removed their assignment Jul 30, 2026
@wlyoon921
wlyoon921 force-pushed the feat/28-notification-read-api branch from 98c15cd to 79483c2 Compare July 30, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant