feat(application): Application 테스트 및 실행 설정 정리 #24 - #64
Open
wlyoon921 wants to merge 4 commits into
Open
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
🚫 Excluded labels (none allowed) (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application 서비스의 bootstrap 실행 설정과 테스트를 정리했습니다.
dev/prod profile별 MySQL 설정을 추가했습니다.
application bootstrap main class와 Bazel 의존성을 정리했습니다.
ScoreCalculator, ApplicationController, EvaluationController 테스트를 추가했습니다.
Related Issue
Related to #24
Scope
In scope:
Out of scope:
Implementation
application 기본 profile은 dev로 구성했습니다.
dev/prod 모두 MySQL datasource와 JPA 설정을 사용하도록 정리했습니다.
랜딩 일정은 APPLICATION_START_AT, APPLICATION_END_AT, RESULT_ANNOUNCED_AT 환경변수로 주입할 수 있게 구성했습니다.
Bazel bootstrap main_class를 실제 Kotlin main class와 일치하도록 수정했습니다.
도메인 점수 계산과 REST controller 응답 흐름을 테스트로 검증했습니다.
Testing
Unit tests:
Manual verification: