Skip to content

fix(cli): hide plugin sync implementation details #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christso merged 2 commits into from
Jul 13, 2026
Merged

fix(cli): hide plugin sync implementation details #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
217d093
fix(cli): keep plugin update progress unified
christso Jul 13, 2026
9f2f2b8
fix(cli): hide plugin sync implementation details
christso Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/cli/tui/actions/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,19 +123,19 @@ export async function installSelectedPlugin(
p.note(result.error ?? 'Unknown error', 'Error');
return false;
}
s.message('Syncing...');
s.message('Updating...');
syncResult = await syncWorkspace(workspacePath);
s.stop('Installed and synced');
s.stop('Installed');
} else {
const result = await addUserPlugin(pluginRef);
if (!result.success) {
s.stop('Installation failed');
p.note(result.error ?? 'Unknown error', 'Error');
return false;
}
s.message('Syncing...');
s.message('Updating...');
syncResult = await syncUserWorkspace();
s.stop('Installed and synced');
s.stop('Installed');
}

cache?.invalidate();
Expand Down Expand Up @@ -171,7 +171,7 @@ async function runUpdatePlugin(
}

// Sync after update
s.message('Syncing...');
s.message('Updating...');
if (scope === 'project' && context.workspacePath) {
await syncWorkspace(context.workspacePath);
} else {
Expand Down Expand Up @@ -242,7 +242,7 @@ export async function runUpdateAllPlugins(

// Sync if any plugins were updated
if (needsProjectSync || needsUserSync) {
s.message('Syncing...');
s.message('Updating...');
if (needsProjectSync && context.workspacePath) {
await syncWorkspace(context.workspacePath);
}
Expand Down Expand Up @@ -446,13 +446,13 @@ async function runPluginDetail(
}

// Sync
s.message('Syncing...');
s.message('Updating...');
if (scope === 'project' && context.workspacePath) {
await syncWorkspace(context.workspacePath);
} else {
await syncUserWorkspace();
}
s.stop('Mode updated and synced');
s.stop('Updated');
cache?.invalidate();

const newMode = currentMode === 'allowlist' ? 'ON' : 'OFF';
Expand Down Expand Up @@ -484,19 +484,19 @@ async function runPluginDetail(
p.note(result.error ?? 'Unknown error', 'Error');
continue;
}
s.message('Syncing...');
s.message('Updating...');
await syncWorkspace(context.workspacePath);
s.stop('Removed and synced');
s.stop('Removed');
} else {
const result = await removeUserPlugin(pluginSource);
if (!result.success) {
s.stop('Removal failed');
p.note(result.error ?? 'Unknown error', 'Error');
continue;
}
s.message('Syncing...');
s.message('Updating...');
await syncUserWorkspace();
s.stop('Removed and synced');
s.stop('Removed');
}

cache?.invalidate();
Expand Down Expand Up @@ -590,13 +590,13 @@ export async function runBrowsePluginSkills(
}

// Auto-sync
s.message('Syncing...');
s.message('Updating...');
if (scope === 'project' && context.workspacePath) {
await syncWorkspace(context.workspacePath);
} else if (scope === 'user') {
await syncUserWorkspace();
}
s.stop('Skills updated and synced');
s.stop('Updated');
cache?.invalidate();

const changes: string[] = [];
Expand Down