fix: remove unused image cache manager override - #2354
Merged
TheNoumanDev merged 1 commit intoAug 27, 2026
Merged
Conversation
| this.placeholderBuilder, | ||
| this.loadingWidget, | ||
| this.colorFilter, | ||
| this.networkCacheManager}); |
Member
There was a problem hiding this comment.
Can you check main branch has this code, and in the main branch, the property name was networkCacheManager or cacheManager, and no flow is broken.
Contributor
Author
There was a problem hiding this comment.
cacheManager name is internal use only and does not change any functionality or flow.
TheNoumanDev
requested changes
Aug 27, 2026
TheNoumanDev
left a comment
Member
There was a problem hiding this comment.
Please verify the rest of your changes, any other stale changes please verify once again against each file, spend an hour on it, so that we dont have to come back again and fix things.
usmanvrtx
force-pushed
the
fix/remove-unused-image-cache-manager
branch
from
August 27, 2026 09:52
f039ef4 to
596d524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
networkCacheManageroverride from theImageandAvatarcontrollers.The override accepted only a runtime
BaseCacheManagerinstance, which cannot be supplied through Ensemble YAML and has no in-repository caller. Image and Avatar continue to use Ensemble's internal cache manager, preserving redirect handling and configured cache behavior.Related Issue
N/A
Type of Change
What Has Changed
networkCacheManagerfields and setters fromImageControllerandAvatarController.EnsembleImageCacheManager.instanceFor(allowRedirect: ...)as the manager used by Image and Avatar network requests.networkCacheManagertocacheManagerto clarify that it forwards the internally selected cache policy.allowRedirect: falseredirect blocking andApp.imageCacheconfiguration for both Image and Avatar.How to Test
Run the focused image widget tests:
Verify an
ImageandAvatarwith a network source still load normally.Verify
allowRedirect: falsecontinues to reject redirected image requests.Verify configured
App.imageCachesettings still apply to network images.Screenshots / Videos
N/A
Checklist
flutter analyzeand addressed any new warningsflutter testand all tests pass