Improve glossary - #1501
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 90.31% 90.35% +0.03%
==========================================
Files 60 61 +1
Lines 8663 8850 +187
Branches 8663 8850 +187
==========================================
+ Hits 7824 7996 +172
- Misses 525 529 +4
- Partials 314 325 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR expands and refines the documentation for MUSE2—primarily by making the glossary substantially more comprehensive—while also updating the circularity example/docs and refreshing the associated golden test data outputs.
Changes:
- Greatly expands
docs/glossary.mdwith clearer, more detailed definitions of key MUSE2 concepts. - Improves user-facing documentation around model validation and settings management (
muse2 validate,muse2 settings ...), and standardises references to “MUSE2”. - Updates the circularity example (removing
capacity_margin) and updates expected outputs intests/data/*accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/data/circularity/commodity_prices.csv | Updates golden commodity price outputs for circularity scenario. |
| tests/data/circularity/commodity_flows.csv | Updates golden commodity flow outputs for circularity scenario. |
| tests/data/circularity/asset_capacities.csv | Updates golden asset capacity outputs for circularity scenario. |
| tests/data/circularity_npv/commodity_prices.csv | Updates golden commodity price outputs for circularity NPV scenario. |
| tests/data/circularity_npv/commodity_flows.csv | Updates golden commodity flow outputs for circularity NPV scenario. |
| tests/data/circularity_npv/asset_capacities.csv | Updates golden asset capacity outputs for circularity NPV scenario. |
| schemas/settings.yaml | Corrects settings file location guidance (platform config dir) and points to muse2 settings path. |
| examples/circularity/README.txt | Removes outdated notes about pricing strategy and needing a wider capacity_margin. |
| examples/circularity/model.toml | Removes capacity_margin from the example model configuration. |
| docs/user_guide.md | Adds muse2 validate guidance, links to settings docs, and standardises “MUSE2” wording. |
| docs/glossary.md | Major glossary expansion and refinement of definitions and terminology. |
Suppressed comments (1)
docs/glossary.md:196
- Markdown emphasis for plurals is currently split ("Processes"), which renders awkwardly. Use a fully pluralised emphasised term ("Processes") instead.
Commodities*. *Process*es have economic attributes of *Capital Cost*, *Fixed Operating Cost* per
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dalonsoa
left a comment
There was a problem hiding this comment.
This looks fantastic - and a lot of work! Not sure if it would help or not, but as this is a list of things, I sort of feel they will be easier to read if we use bullet points.
| *Asset* with a 25 MW *Unit Size* has four units, which can be retained or mothballed independently. | ||
|
|
||
| **Utilisation:** The percentage of an *Asset*'s *Capacity* that is actually used to produce its | ||
| *Commodities*. Must be between 0 and 1, and can be measured at *Time Slice*, *Season*, or *Year* level. |
There was a problem hiding this comment.
Must be between 0 and 1
inclusive, presumably?
Description
This makes the glossary a bit more comprehensive.
A few other small changes thrown in:
circularitymodel readme, and I also noticed that increasingcapacity_marginis no longer necessaryvalidatecommand to the user guidemuse2 settingscommand docs to the user guideMUSE2throughout rather thanMUSEFixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks