Skip to content

Add some code to facilitating the debugging of bad test data from a source #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwant wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some code to facilitating the debugging of bad test data from a source #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/views/sources/_test_resource_error.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<div class="list-card bulk-import-row alert alert-danger">
<h4><%= "#{t('sources.testing.error.title')} (#{resource_type})" %></h4>
<p class="pt-2">
<div><%= t('sources.testing.error.input_data') %></div>
<pre><%= JSON.pretty_generate(resource_params) %></pre>
<div><%= "#{t('sources.testing.error.message')} #{exception.message}" %></div>
<pre><%= exception.backtrace.first(3).join('<br>').html_safe %></pre>
</p>
</div>
14 changes: 11 additions & 3 deletions app/views/sources/_test_results.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,17 @@
Showing <%= pluralize(sample.count, 'sample') %>
<% end %>
<% sample.each do |resource_params| %>
<% resource = Source.get_test_resource(type, resource_params, user: User.get_default_user,
content_provider: @content_provider) %>
<%= render partial: 'sources/test_resource', locals: { resource: resource, resource_params: resource_params } %>
<% begin %>
<% resource = Source.get_test_resource(type, resource_params, user: User.get_default_user,
content_provider: @content_provider) %>
<%= render partial: 'sources/test_resource', locals: { resource: resource,
resource_params: resource_params } %>
<% rescue StandardError => e %>
<%= render partial: 'sources/test_resource_error',
locals: { resource_params: resource_params,
resource_type: type,
exception: e } %>
<% end %>
<% end %>
<% end %>
<% end %>
Expand Down
5 changes: 5 additions & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,11 @@ en:
filters: Filters
allow_list: Allow List
block_list: Block List
testing:
error:
title: "Error rendering test ingestion!"
input_data: "Input data:"
message: "Error message:"
prompts:
default_language: 'Select a default language...'
scraper:
Expand Down