Update cargo-rbmt and fix CI#266
Merged
delta1 merged 7 commits intoElementsProject:masterfrom Apr 22, 2026
Merged
Conversation
apoelstra
force-pushed
the
2026-04/fix-ci
branch
5 times, most recently
from
c76bed4 to
2cfcd77
Compare
This copies the rust.yml file from rust-bech32 verbatim *except*
* I changed the lockfile list from {recent, minimal} to just {recent}. Also,
since "recent" appears in a ton of places, I just renamed Cargo-latest.lock
to Cargo-recent.lock instead of changing the CI file.
* I deleted the "embedded" job which refers to a test that doesn't exist here.
* Added setting of ELEMENTSD_EXE env var, needed for the elememntsd tests
* I commented out the fmt job, which was commented out before, and which would
require a 2000-line diff to re-enable (though maybe we should..)
* I re-added the WASM job from the old file, since cargo-rbmt doesn't do WASM
(I think) and urprisingly that old job was still passing, so I figured we
should keep it. If anything breaks going forward, it'll be this one.
apoelstra
force-pushed
the
2026-04/fix-ci
branch
2 times, most recently
from
719716b to
ab873ec
Compare
apoelstra
force-pushed
the
2026-04/fix-ci
branch
from
ab873ec to
85122db
Compare
Member
Author
|
cc @delta1 can you take a look at this? A cursory review is fine, this stuff is CI only. |
With the move to the latest cargo-rbmt we have replaced our nightly-version files with Cargo.toml entries. Update the cronjob accordingly, and add a new one for the stable compiler version. This moves the update date from Mondays to Saturdays. It's a bit nicer to have Saturday, both because this is the same time as all the other rust-bitcoin PRs are opened so I can bulk-review them, but also because it means I can merge these (usually trivial) PRs on Sunday and not have them mixed up with activity during the workweek.
These two expressions were quite confusingly constructed.
I split out the previous lint fix because touching boolean expressions always makes me nervous. These ones are mechanical changes that do not make me nervous.
This matches rust-bitcoin.
apoelstra
force-pushed
the
2026-04/fix-ci
branch
from
85122db to
89f15f4
Compare
Member
Author
|
On 89f15f4 successfully ran local tests |
delta1
approved these changes
Apr 22, 2026
Member
delta1
left a comment
delta1
left a comment
There was a problem hiding this comment.
ACK 89f15f4; ran tests locally
Thanks for fixing the CI @apoelstra !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overhauls the CI system (again) by copying all the files from rust-bech32 and rust-bitcoin and making minor tweaks for rust-elements.
This should fix the
doc_auto_cfgthing which is plaguing #257, and should overall be much more reliable going forward since it's much more agressive about pinning toolchain versions etc.This does not re-enable the fuzz tests (which were not covered by the previous CI and not covered by this one); do this will require I migrate the old honggfuzz-based fuzz targets to cargo-fuzz ones, and require I migrate the ancient travis-fuzz.sh script to our more modern one. Will do this in a separate PR.