Skip to content

channeld: document that local funding pubkey is fixed for splices #9521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andezion wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

channeld: document that local funding pubkey is fixed for splices #9521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions channeld/channeld.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4377,6 +4377,7 @@ static void splice_accepter(struct peer *peer, const u8 *inmsg)
peer->splicing->accepter_relative = 0;

if (type == WIRE_SPLICE_INIT) {
/* Same fixed local funding_pubkey as splice_init - see the comment there */
msg = towire_splice_ack(NULL,
&peer->channel_id,
peer->splicing->accepter_relative,
Expand Down Expand Up @@ -5031,6 +5032,9 @@ static void handle_splice_stfu_success(struct peer *peer)
u8 *msg;
struct tlv_tx_init_rbf_tlvs *init_rbf_tlvs;
if (!last_inflight(peer)) {
/* We only support the peer rotating their funding pubkey
* (see remote_funding_pubkey) - our own funding_pubkey is
* fixed for the channel's lifetime and is never rederived here */
msg = towire_splice_init(tmpctx,
&peer->channel_id,
peer->splicing->opener_relative,
Expand Down
3 changes: 2 additions & 1 deletion channeld/splice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ struct splice_state *splice_state_new(const tal_t *ctx);
/* An active splice negotiation. Born when splice beings and dies when a splice
* negotation has finished */
struct splicing {
/* The remote side's rotated funding pubkey */
/* The remote side's rotated funding pubkey. There is no local counterpart - we always reuse channel->funding_pubkey[LOCAL],
* which is fixed for the channel's lifetime. Local funding pubkey rotation is not implemented */
struct pubkey remote_funding_pubkey;
/* The opener side's relative balance change */
s64 opener_relative;
Expand Down
Loading