repro-build: pass VERSION to the install step - #9514
Open
kwsantiago wants to merge 1 commit into
Open
kwsantiago wants to merge 1 commit into
kwsantiago wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/repro-build.shpassesVERSIONto the build but not tomake install.version_gen.hdepends on$(FORCE), so the install step regenerates it fromgit describeand relinks, and the installed binaries report the describe string rather than the requested version.It is invisible when building from an exact tag, where the two agree, and shows up when
FORCE_VERSIONis used anywhere else.Full repro build of master at a34b975 with
FORCE_VERSION=v26.06.7-prtest:Version updatedappears twice in the build log before the change and once after.