tests: fix test_htlc_no_force_close flake - #9505
Open
daywalker90 wants to merge 1 commit into
Open
daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
Changelog-None
Andezion
reviewed
Sep 18, 2026
Andezion
left a comment
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
is it expected that htlc_txs could contain more than one tx matching vin['txid'] == commit_txid? if so, does releasing all of them (including possibly superseded rbf attempts) cause any issue, or is sendrawtransaction on stale RBF attempts just silently rejected and harmless (caught by the existing except bitcoin.rpc.VerifyError)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-None
Fixes: #9502