Skip to content

tests: fix test_htlc_sig_persistence flake #9503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daywalker90 merged 1 commit into from
Sep 18, 2026
+6 −1
Merged

tests: fix test_htlc_sig_persistence flake #9503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,12 @@ def test_htlc_sig_persistence(node_factory, bitcoind, executor, chainparams):
l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
l1.fundchannel(l2, 10**6)
f = executor.submit(l1.pay, l2, 31337000)
l1.daemon.wait_for_log(r'HTLC out 0 RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION')
# Wait until the executor thread is blocked in `waitsendpay` before we
# stop: if l1 goes down before that RPC connects, the executor raises
# ConnectionRefusedError instead of the RpcError we expect below. Order
# is not guaranteed, since the thread can be delayed scheduling the RPC.
l1.daemon.wait_for_logs([r'Payment part [0-9]+/[0-9]+/[0-9]+ status',
r'HTLC out 0 RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION'])
l1.stop()

# `pay` call is lost
Expand Down
Loading