CI: restructure release workflows#9346
Open
daywalker90 wants to merge 2 commits into
Open
Conversation
After 608f695 the vls docker image build fails because it is missing protoc. ``` > [vls-builder 9/10] RUN cargo build --release --target x86_64-unknown-linux-gnu: 177.2 177.2 Caused by: 177.2 process didn't exit successfully: `/opt/validating-lightning-signer/target/release/build/lightning-storage-server-85c73031cf3e0f51/build-script-build` (exit status: 1) 177.2 --- stdout 177.2 cargo:rerun-if-changed=proto/lss.proto 177.2 cargo:rerun-if-changed=proto 177.2 177.2 --- stderr 177.2 Error: Custom { kind: NotFound, error: "Could not find `protoc`. If `protoc` is installed, try setting the `PROTOC` environment variable to the path of the `protoc` binary. To install it on Debian, run `apt-get install protobuf-compiler`. It is also available at https://github.com/protocolbuffers/protobuf/releases For more information: https://docs.rs/prost-build/#sourcing-protoc" } 177.2 warning: build failed, waiting for other jobs to finish... ``` vls 0.14 also has an external dependency that requires protoc, so vls vendoring it would not be enough.
Binaries, docker images, and python packages are now separated into build and publish flows. First everything gets built and if every build step succeeds the publish step can continue. Also fan out the docker build into a matrix to speed up the workflow. Changelog-None
daywalker90
force-pushed
the
release-atomic
branch
from
July 23, 2026 12:17
08f0e0b to
1a22d0e
Compare
daywalker90
added
the
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binaries, docker images, and python packages are now separated into
build and publish flows. First everything gets built and if every build
step succeeds the publish step can continue.
Also fan out the docker build into a matrix over the targets, to speed up the workflow.
Patch version rc tags are now also valid.
During testing i discovered that the vls docker image build fails
because it is missing protoc, so i included a fix here.