plugins: rename bwatch output binary to cln-bwatch#9192
Open
sangbida wants to merge 1 commit into
Open
Conversation
The bwatch plugin lived in plugins/bwatch/ and output its binary as plugins/bwatch/bwatch. This caused make install to install it flat as <plugindir>/bwatch, while lightningd expected it at <plugindir>/bwatch/bwatch, so plugin registration failed at startup with "failed to register plugin". Fix by renaming the output to plugins/cln-bwatch, following the same convention as cln-renepay, cln-xpay and cln-askrene. Changelog-Fixed: bwatch plugin failed to register on startup after make install
Collaborator
Author
|
I tried to reproduce the issue locally as well, before the fix: After the fix: |
madelinevibes
added
26.06.1
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bwatch plugin lived in plugins/bwatch/ and output its binary as plugins/bwatch/bwatch. This caused make install to install it flat as /bwatch, while lightningd expected it at /bwatch/bwatch, so plugin registration failed at startup with "failed to register plugin".
Fix by renaming the output to plugins/cln-bwatch, following the same convention as cln-renepay, cln-xpay and cln-askrene.
Changelog-Fixed: bwatch plugin failed to register on startup after make install
Fixes #9191