Conversation
🦋 Changeset detectedLatest commit: d95244a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Moving @types/ws to devDependencies in @effect/platform-node-shared will break TypeScript consumers because ws does not ship its own declarations and the package publicly re-exports the ws namespace.
Reviewed changes
- Updated peer dependency ranges across 11 packages to explicit
>=x <yintervals. - Removed exact-version pinning for several devDependencies (
react,react-dom,vitest,@types/doctrine, etc.). - Bumped peer lower bounds for React, scheduler, SolidJS, Vue, op-sqlite, and Vite to current workspace versions.
- Moved
@types/wsfromdependenciestodevDependenciesin@effect/platform-node-shared. - Regenerated
pnpm-lock.yamlto match the package.json changes.
ℹ️ Peer-dependency lower bounds may be narrower than necessary
The new lower bounds (e.g., react >=19.2.7, solid-js >=1.9.14, vue >=3.5.39, @op-engineering/op-sqlite >=17.1.2, vite >=8.1.5) match the workspace's current dev versions, but the source uses APIs available in older releases. Unless a specific runtime feature or type requires those minima, keeping the lower bound at the oldest supported version avoids breaking consumers who are still on earlier patches. Please confirm whether each bumped lower bound is intentional and required.
@v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
70157fe to
9c44758
Compare
|
Run failed. View the logs →
|
There was a problem hiding this comment.
Important
The changeset still lists @effect/platform-node-shared for a patch release, but the corresponding package.json change was removed in this revision. This would produce a no-op patch with a misleading changelog entry.
Reviewed changes
- Reverted the
@types/wsdependency move in@effect/platform-node-shared, leaving it independenciesas required. - Retained peer-dependency range conversions to explicit
>=x <yintervals across the other packages. - Retained the lower-bound bumps for React, scheduler, SolidJS, Vue, op-sqlite, and Vite.
- Regenerated
pnpm-lock.yamlto match the specifier updates.
⚠️ Stale changeset entry for @effect/platform-node-shared
The changeset includes a patch entry for @effect/platform-node-shared, but no file in that package changed in this revision. This will trigger a no-op release and record "Update peer dependencies" in its changelog even though its package.json was not touched.
Technical details
# Stale changeset entry
## Affected sites
- `.changeset/dry-bugs-hug.md:9` — `@effect/platform-node-shared: patch` without a matching package change
## Required outcome
- Remove the `@effect/platform-node-shared` line from the changeset, or re-add the intended package change.@v0 or keep the SHA fresh with Dependabot ｜ Fix it ➔ ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Removed the stale
@effect/platform-node-shared: patchentry from.changeset/dry-bugs-hug.md, resolving the prior concern that the package would receive a no-op patch release. - No other files changed since the prior Pullfrog review.
The prior informational note about peer-dependency lower bounds being potentially narrower than necessary is unchanged by this delta.
@v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ Using Kimi K2 (free via Pullfrog for OSS) ｜ 𝕏
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
2 participants
No description provided.