fix(Record): make fromIterableBy dual for pipe-friendly usage#6212
Open
lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
Open
fix(Record): make fromIterableBy dual for pipe-friendly usage#6212lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
Wraps `Record.fromIterableBy` with `dual(2, ...)` so it supports both data-first and data-last (curried) calling conventions, consistent with `fromIterableWith` and other dual APIs in the codebase. Closes Effect-TS#6092
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps
Record.fromIterableBywithdual(2, ...)so it supports both data-first and data-last (curried) calling conventions, consistent withfromIterableWithand other dual APIs in the codebase.This enables the following pipe-friendly usage:
Closes #6092
Test plan
Record.fromIterableBy(items, fn)pipe(items, Record.fromIterableBy(fn))