Skip to content

Remove wrong link to source description#44

Merged
fmacca merged 1 commit into
developfrom
43-bug-the-source-description-should-be-given-in-a-different-tei-file-or-not-given-it-should-not-point-to-the-same-mei-file
Jul 15, 2026
Merged

Remove wrong link to source description#44
fmacca merged 1 commit into
developfrom
43-bug-the-source-description-should-be-given-in-a-different-tei-file-or-not-given-it-should-not-point-to-the-same-mei-file

Conversation

@fmacca

@fmacca fmacca commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description, Context and related Issue

I remove wrong links to source descriptions that are self-pointing to the source instead than to a tei file.
This makes the source description disappear from getLinkTarget and from the frontend. Before, a black screen appeared.

It might be better to create demo source description tei files for some of the sources instead.

Refs #43

How Has This Been Tested?

Tested with the develop branch of Frontend and Backend

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@daniel-jettka daniel-jettka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have create a separate issue for adding appropriate descriptions - #45

@github-project-automation github-project-automation Bot moved this from In Progress to Approved in Edirom Development Jul 15, 2026
@fmacca fmacca merged commit 4f4b435 into develop Jul 15, 2026
@github-project-automation github-project-automation Bot moved this from Approved to Done in Edirom Development Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] The source description should be given in a different TEI file, or not given. It should not point to the same mei file

2 participants