Gate balance effects and FIO refresh on engine readiness (wallet cache v2)

[j0ntz]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

EdgeApp/edge-core-js#733

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

Description

GUI-side patches for wallet cache v2 phase 1 (TDD section 7: immutable snapshot). With EdgeApp/edge-core-js#733, wallet objects exist before their engines load and waitForAllWallets resolves in that window, so the login-path surfaces that consumed engine state at resolve-time are gated on engine readiness:

• checkActionEffect.ts (address-balance): reported the effect against balanceMap immediately after awaiting the wallet, which could now evaluate cached, possibly stale balances. It reports not-yet-effective until the engine has fully synced (same conservatism as the loan flow's waitForLoanAccountSync and the existing < 1 treatment in spend paths, TDD 7.4), letting the action queue's normal 15s poll re-check.
• Services.tsx: the post-waitForAllWallets FIO refreshes (refreshConnectedWallets, refreshAllFioAddresses) call wallet.otherMethods.*, which the core guarantees is {} pre-engine. A new waitForWalletOtherMethods util watches otherMethods until the engine's methods land (10-minute safety-valve timeout, roughly matching how long waitForAllWallets could already take on large accounts before the cache existed).
• FioService.ts: the periodic expired-domain check calls otherMethods.getFioAddresses the same way. This one was NOT in the TDD's section-7 audit; it was caught live on the simulator (red dev alert wallet.otherMethods.getFioAddresses is not a function seconds after a warm cached login). Being a 30s periodic task, it skips pre-engine wallets and lets the next cycle retry, which also avoids wedging its one-shot expiredChecking latch when no wallet is ready yet.

Remaining otherMethods call sites (FIO scenes, staking, WalletConnect) are user-navigation surfaces audited in the TDD as safe (null-probes, or flows that imply an engine exists) and are unchanged.

Tested on the iOS simulator against the linked core build (edge-funds, 194 wallets): cold login wrote all 194 walletCache.json files; warm relaunch rendered the full wallet list with names and balances from the cache while engines were still loading; no FIO alert through 140s of runtime; drilling into a wallet shows live engine-backed data on the same wallet object. Screenshots attached below.

Asana: https://app.asana.com/1/9976422036640/project/1213843652804305/task/1216673467164267

---

Note

Medium Risk
Touches login-time FIO refresh and action-queue balance gating on engine/sync state; mistakes could delay automations or skip FIO updates, but changes are conservative (wait/retry, no user-auth changes).

Overview
Adapts the GUI for wallet cache v2, where wallet objects appear before their engines finish loading and waitForAllWallets can resolve in that window.

Action queue: address-balance effects no longer compare balances immediately after waitForCurrencyWallet. They stay not effective until syncStatus.totalRatio reaches DONE_THRESHOLD, so cached balances are not used; the existing 15s poll retries.

Login FIO path: After waitForAllWallets, Services waits per FIO wallet via new waitForWalletOtherMethods (watches otherMethods, 10‑minute timeout, per-wallet errors logged) and bails if the account logged out before running refreshConnectedWallets / refreshAllFioAddresses.

FioService: The periodic expired-domain check only runs against wallets where getFioAddresses exists, uses try/finally so expiredChecking cannot stick, and retries on later cycles. ESLint no longer exempts FioService.ts from the services lint list.

^{Reviewed by Cursor Bugbot for commit 0a089ca. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[j0ntz]

📸 Test evidence (iOS sim, edge-funds)

agent proof 1216673467164267 01 cold login wallet list

agent proof 1216673467164267 02 warm login cached wallet list

agent proof 1216673467164267 03 wallet detail engine loaded

Captured by the agent's in-app test run (build-and-test).

[j0ntz]

📸 Test evidence (after review fixes)

agent proof 1216673467164267 04 warm login after review fixes

Captured by the agent's in-app test run (build-and-test).

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0a089ca. Configure here.}