Skip to content

Add n.exchange transaction icon mapping#6079

Merged
j0ntz merged 1 commit into
developfrom
jon/nexchange-transaction-icon
Jul 18, 2026
Merged

Add n.exchange transaction icon mapping#6079
j0ntz merged 1 commit into
developfrom
jon/nexchange-transaction-icon

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

n.exchange (nexchange) swap transactions rendered the generic "Swap Funds" icon in transaction history and details because pluginIdIcons in src/actions/CategoriesActions.ts had no entry for the nexchange plugin id. This adds that mapping so the partner icon renders.

Path note: the icon asset is served at https://content.edge.app/exchangeIcons/nexchange/icon.png (verified 200 image/png), not the flat /nexchange.png path used by EdgeApp/edge-react-gui#6075 (403). This uses the exchangeIcons/<pluginId>/icon.png convention, the same pattern already merged for nymswap in EdgeApp/edge-react-gui#6078.

Supersedes #6075 with the corrected icon path.

Testing: forced pluginIdIcons lookup to nexchange on existing swap transaction rows via a throwaway local harness (reverted before commit) and confirmed the n.exchange logo loads from the content server and renders in both the transaction list and transaction detail scene on the iOS simulator (edge-funds, My Base 4 wallet). tsc, jest, and eslint pass via verify-repo.sh. Proof screenshots attached below.

Asana task: https://app.asana.com/0/0/1214071268047343


Note

Low Risk
Display-only icon URL mapping with no auth, payment, or swap logic changes.

Overview
n.exchange swap rows no longer fall back to the generic swap icon in transaction list and transaction details.

Adds nexchange to pluginIdIcons in CategoriesActions.ts, loading the partner logo from exchangeIcons/nexchange/icon.png on the content server (same convention as nymswap). CHANGELOG updated under 4.50.0.

Reviewed by Cursor Bugbot for commit 7c965bc. Bugbot is set up for automated code reviews on this repo. Configure here.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

@j0ntz

j0ntz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

agent proof 1214071268047343 01 nexchange icon list

agent proof 1214071268047343 01 nexchange icon list

agent proof 1214071268047343 02 nexchange icon detail

agent proof 1214071268047343 02 nexchange icon detail

Captured by the agent's in-app test run (build-and-test).

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Map the nexchange swap plugin id to its CDN icon so transaction
history and detail scenes show the n.exchange logo instead of the
generic swap icon.
@j0ntz
j0ntz force-pushed the jon/nexchange-transaction-icon branch from c020347 to 7c965bc Compare July 17, 2026 23:24
@j0ntz
j0ntz enabled auto-merge July 17, 2026 23:24
@j0ntz
j0ntz merged commit 4e553a1 into develop Jul 18, 2026
7 checks passed
@j0ntz
j0ntz deleted the jon/nexchange-transaction-icon branch July 18, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant