Add n.exchange transaction icon mapping#6079
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Map the nexchange swap plugin id to its CDN icon so transaction history and detail scenes show the n.exchange logo instead of the generic swap icon.
j0ntz
force-pushed
the
jon/nexchange-transaction-icon
branch
from
July 17, 2026 23:24
c020347 to
7c965bc
Compare
j0ntz
enabled auto-merge
July 17, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
n.exchange (
nexchange) swap transactions rendered the generic "Swap Funds" icon in transaction history and details becausepluginIdIconsinsrc/actions/CategoriesActions.tshad no entry for thenexchangeplugin id. This adds that mapping so the partner icon renders.Path note: the icon asset is served at
https://content.edge.app/exchangeIcons/nexchange/icon.png(verified200 image/png), not the flat/nexchange.pngpath used by EdgeApp/edge-react-gui#6075 (403). This uses theexchangeIcons/<pluginId>/icon.pngconvention, the same pattern already merged fornymswapin EdgeApp/edge-react-gui#6078.Supersedes #6075 with the corrected icon path.
Testing: forced
pluginIdIconslookup tonexchangeon existing swap transaction rows via a throwaway local harness (reverted before commit) and confirmed the n.exchange logo loads from the content server and renders in both the transaction list and transaction detail scene on the iOS simulator (edge-funds, My Base 4 wallet).tsc, jest, and eslint pass viaverify-repo.sh. Proof screenshots attached below.Asana task: https://app.asana.com/0/0/1214071268047343
Note
Low Risk
Display-only icon URL mapping with no auth, payment, or swap logic changes.
Overview
n.exchange swap rows no longer fall back to the generic swap icon in transaction list and transaction details.
Adds
nexchangetopluginIdIconsinCategoriesActions.ts, loading the partner logo fromexchangeIcons/nexchange/icon.pngon the content server (same convention asnymswap). CHANGELOG updated under 4.50.0.Reviewed by Cursor Bugbot for commit 7c965bc. Bugbot is set up for automated code reviews on this repo. Configure here.