fix: sanitize Eino reduction paths on Windows - #283
Open
alexiss31 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Sur Windows, certains identifiants CallID Eino générés pour les tool calls contiennent le caractère | (par exemple call_...|fc_...). Le middleware de réduction réutilisait cet identifiant tel quel dans les chemins tmp/reduction/.../trunc et clear, ce qui provoquait une erreur NodeRunError fatale : The filename, directory name, or volume label syntax is incorrect.
Les événements « audit agent rejected » observés dans la conversation sont séparés : ils correspondent à un échec d’appel du LLM d’audit et restent des refus de sécurité souples, sans auto-approbation.
Correctif
Vérification
Périmètre
Cette PR ne contient que les 4 fichiers nécessaires : 2 fichiers de production et leurs 2 tests. Aucun refactor ni fichier généré.