Adding and updating DHL eCommerce carrier curls for Wallet and BYOCA - #228
Merged
skappa (skappaep) merged 7 commits intoAug 5, 2026
Merged
Conversation
Justin Hammond (Justintime50)
left a comment
Justin Hammond (Justintime50)
left a comment
Member
There was a problem hiding this comment.
What makes DHLECS a custom workflow carrier now? Usually custom workflow carriers do not use the traditional credentials structure but this appears to still use it.
Contributor
Author
|
Good point, it's not actually a custom workflow in the usual sense. I added carrier-specific handling because we now need it to generate two files: the BYOCA cURL and a separate Wallet cURL. |
Rane Gridley (ranebo)
approved these changes
Aug 4, 2026
Justin Hammond (Justintime50)
approved these changes
Aug 5, 2026
Justin Hammond (Justintime50)
left a comment
Justin Hammond (Justintime50)
left a comment
Member
There was a problem hiding this comment.
Nice work! 2 small formatting things
Co-authored-by: Justin Hammond <justinpaulhammond@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.