Merged
Conversation
…_queue_lock _queue_lock is a lock guarding the queues and should not be used to guard the internal client pointer
Member
Author
|
@MitchBradley FYI |
mathieucarbou
commented
Apr 10, 2026
| } | ||
|
|
||
| void AsyncWebSocketClient::_onTimeout(uint32_t time) { | ||
| asyncsrv::lock_guard_type lock(_lock); |
Member
Author
There was a problem hiding this comment.
Removed because this is wrong to use the _queue_lock to protect the _client ptr (which is not guarded anywhere else it should be)
mathieucarbou
commented
Apr 10, 2026
| } | ||
|
|
||
| void AsyncWebSocketClient::_onDisconnect() { | ||
| asyncsrv::lock_guard_type lock(_lock); |
Member
Author
There was a problem hiding this comment.
Removed because this is wrong to use the _queue_lock to protect the _client ptr (which is not guarded anywhere else it should be)
mathieucarbou
commented
Apr 10, 2026
| #endif | ||
|
|
||
| IPAddress AsyncWebSocketClient::remoteIP() const { | ||
| asyncsrv::lock_guard_type lock(_lock); |
Member
Author
There was a problem hiding this comment.
Removed because this is wrong to use the _queue_lock to protect the _client ptr (which is not guarded anywhere else it should be)
mathieucarbou
commented
Apr 10, 2026
| } | ||
|
|
||
| uint16_t AsyncWebSocketClient::remotePort() const { | ||
| asyncsrv::lock_guard_type lock(_lock); |
Member
Author
There was a problem hiding this comment.
Removed because this is wrong to use the _queue_lock to protect the _client ptr (which is not guarded anywhere else it should be)
…nnnect could set it to null
mathieucarbou
force-pushed
the
locking
branch
2 times, most recently
from
e4bb562 to
99d9464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the _lock variables to a better name to match what they guard exactly.
_queue_lock is a lock guarding the queues and should not be used to guard the internal client pointer.
This is a fix of PR #427 and commit 085f278