Fix intake-esgf CMIP7 support - #3221
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
- Coverage 96.50% 96.47% -0.03%
==========================================
Files 282 282
Lines 16416 16418 +2
==========================================
- Hits 15842 15840 -2
- Misses 574 578 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks a lot @bouweandela ! works for me 🎉 |
valeriupredoi
left a comment
There was a problem hiding this comment.
looks spiffy, and thanks to @katjaweigel we knoe it also works, cheers @bouweandela 🍻 Do you also want to pop a minimal test case in tests? If there 'snt one yet
|
Thanks for testing and reviewing! There is a test here: https://github.com/ESMValGroup/ESMValCore/pull/3221/changes#diff-b08b62643b473104ca4980f5735d47183806232747f18ed8fc56c9bb11639ccd, what other testing would you suggest? |
I was suggesting exactly that one! For some odd reason my browser missed that file, and now I see it missed a few more. Checked them now - all good! 🍺 |
though, now being a world champion at nitpicking, could you chose an even more obscure variable for the test, please? 🤣 |
Description
Some changes are needed to make accessing CMIP7 data with intake-esgf possible. The lowest version of intake-esgf that supports CMIP7 is v2026.9.4. Run
esmvaltool config copy data-intake-esgf.ymlto install the configuration file. Ensure that at least one of the new STAC indices are enabled, i.e. the file~/.config/intake-esgf/conf.yamlcontains the lines:Example recipe for testing this pull request:
Closes #issue_number
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: