Skip to content

Fix intake-esgf CMIP7 support - #3221

Merged
bouweandela merged 5 commits into
mainfrom
fix-intake-esgf-cmip7-support
Sep 18, 2026
Merged

bouweandela merged 5 commits into
mainfrom
fix-intake-esgf-cmip7-support

Conversation

@bouweandela

@bouweandela bouweandela commented Sep 16, 2026

Copy link
Copy Markdown
Member

Description

Some changes are needed to make accessing CMIP7 data with intake-esgf possible. The lowest version of intake-esgf that supports CMIP7 is v2026.9.4. Run esmvaltool config copy data-intake-esgf.yml to install the configuration file. Ensure that at least one of the new STAC indices are enabled, i.e. the file ~/.config/intake-esgf/conf.yaml contains the lines:

stac_indices:
  discovery.east.esgf.io: true
  discovery.west.esgf.io: true

Example recipe for testing this pull request:

# ESMValTool
# recipe_python.yml
#
# See https://docs.esmvaltool.org/en/latest/recipes/recipe_examples.html
# for a description of this recipe.
#
# See https://docs.esmvaltool.org/projects/esmvalcore/en/latest/recipe/overview.html
# for a description of the recipe format.
---
documentation:
  description: |
    Example recipe that plots a map and timeseries of temperature.

  title: Recipe that runs an example diagnostic written in Python.

  authors:
    - andela_bouwe
    - righi_mattia

  maintainer:
    - schlund_manuel

  references:
    - acknow_project

  projects:
    - esmval
    - c3s-magic

datasets:
  - {dataset: UKCM2a-0-HH, project: CMIP7, mip: atmos, exp: historical, ensemble: r1i1p1f1, grid: g137}
  - {dataset: UKCM2-0-LL, project: CMIP7, mip: atmos, exp: historical, ensemble: r1i1p1f1, grid: g110}
  - {dataset: CanESM6-0-MR, project: CMIP7, mip: atmos, exp: historical, ensemble: r1i1p1f1, grid: g150}

preprocessors:
  # See https://docs.esmvaltool.org/projects/esmvalcore/en/latest/recipe/preprocessor.html
  # for a description of the preprocessor functions.

  to_degrees_c:
    convert_units:
      units: degrees_C

diagnostics:

  map:
    description: Global map of temperature in January 2000.
    themes:
      - phys
    realms:
      - atmos
    variables:
      tas:
        branding_suffix: tavg-h2m-hxy-u
        frequency: mon
        region: glb
        preprocessor: to_degrees_c
        timerange: 2000/P1M
        caption: |
          Global map of {long_name} in January 2000 according to {dataset}.
    scripts:
      script1:
        script: examples/diagnostic.py
        quickplot:
          plot_type: pcolormesh
          cmap: Reds

Closes #issue_number

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (19eb140) to head (5f70fbb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
- Coverage   96.50%   96.47%   -0.03%     
==========================================
  Files         282      282              
  Lines       16416    16418       +2     
==========================================
- Hits        15842    15840       -2     
- Misses        574      578       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@katjaweigel

Copy link
Copy Markdown
Contributor

Thanks a lot @bouweandela ! works for me 🎉

@bouweandela bouweandela added the bug Something isn't working label Sep 18, 2026
@bouweandela
bouweandela marked this pull request as ready for review September 18, 2026 09:24

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks spiffy, and thanks to @katjaweigel we knoe it also works, cheers @bouweandela 🍻 Do you also want to pop a minimal test case in tests? If there 'snt one yet

@bouweandela

Copy link
Copy Markdown
Member Author

Thanks for testing and reviewing! There is a test here: https://github.com/ESMValGroup/ESMValCore/pull/3221/changes#diff-b08b62643b473104ca4980f5735d47183806232747f18ed8fc56c9bb11639ccd, what other testing would you suggest?

@valeriupredoi

Copy link
Copy Markdown
Contributor

Thanks for testing and reviewing! There is a test here: https://github.com/ESMValGroup/ESMValCore/pull/3221/changes#diff-b08b62643b473104ca4980f5735d47183806232747f18ed8fc56c9bb11639ccd, what other testing would you suggest?

I was suggesting exactly that one! For some odd reason my browser missed that file, and now I see it missed a few more. Checked them now - all good! 🍺

@valeriupredoi

Copy link
Copy Markdown
Contributor

Thanks for testing and reviewing! There is a test here: https://github.com/ESMValGroup/ESMValCore/pull/3221/changes#diff-b08b62643b473104ca4980f5735d47183806232747f18ed8fc56c9bb11639ccd, what other testing would you suggest?

I was suggesting exactly that one! For some odd reason my browser missed that file, and now I see it missed a few more. Checked them now - all good! 🍺

though, now being a world champion at nitpicking, could you chose an even more obscure variable for the test, please? 🤣

@bouweandela
bouweandela merged commit 2f24941 into main Sep 18, 2026
5 checks passed
@bouweandela
bouweandela deleted the fix-intake-esgf-cmip7-support branch September 18, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants