Added getCols and getRows methods to the csharp wrapper#3029
Closed
Carl-Hossler wants to merge 2 commits into
Closed
Added getCols and getRows methods to the csharp wrapper#3029Carl-Hossler wants to merge 2 commits into
Carl-Hossler wants to merge 2 commits into
Conversation
Extended csharp wrapper for the following methods: getColsByRange, getColsBySet, getColsByMask, getRowsByRange, getRowsBySet, getRowsByMask
Member
|
Thanks. Note that PRs are made to latest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3029 +/- ##
==========================================
- Coverage 81.28% 81.26% -0.02%
==========================================
Files 358 358
Lines 88720 88641 -79
==========================================
- Hits 72119 72038 -81
- Misses 16601 16603 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you @Carl-Hossler! Please remove the costs from the row methods, this is why several of the CI tests are failing |
Removed costs argument for the getRows methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended csharp wrapper for the following methods: getColsByRange, getColsBySet, getColsByMask, getRowsByRange, getRowsBySet, getRowsByMask