Skip to content

sanitizer tests#3025

Open
galabovaa wants to merge 3 commits into
hmw-mtfrom
hmw-mt-san
Open

sanitizer tests#3025
galabovaa wants to merge 3 commits into
hmw-mtfrom
hmw-mt-san

Conversation

@galabovaa
Copy link
Copy Markdown
Contributor

@galabovaa galabovaa commented May 15, 2026

std::vector is the one STL container with no element-independence guarantee

@galabovaa galabovaa requested review from Opt-Mucca and jajhall May 15, 2026 14:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (1271284) to head (5c07d5b).
⚠️ Report is 9 commits behind head on hmw-mt.

Additional details and impacted files
@@            Coverage Diff             @@
##           hmw-mt    #3025      +/-   ##
==========================================
- Coverage   72.82%   72.81%   -0.02%     
==========================================
  Files         420      420              
  Lines      103242   103232      -10     
  Branches    16636    16632       -4     
==========================================
- Hits        75191    75170      -21     
- Misses      27775    27786      +11     
  Partials      276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Opt-Mucca Opt-Mucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galabovaa only one point (I do think that should be changed though).

Is enabling the sanitizers going to cause test times in general to now increase a lot?

Comment thread highs/lp_data/HStruct.h Outdated
std::vector<double> submip_start_time;
std::vector<HighsInt> submip_clock_running;
std::vector<bool> submip;
std::vector<char> submip;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing this to uint8_t

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do

@galabovaa
Copy link
Copy Markdown
Contributor Author

@galabovaa only one point (I do think that should be changed though).

Is enabling the sanitizers going to cause test times in general to now increase a lot?

We should just run it on PR, but until all is in latest I left it on push 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants