sanitizer tests#3025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hmw-mt #3025 +/- ##
==========================================
- Coverage 72.82% 72.81% -0.02%
==========================================
Files 420 420
Lines 103242 103232 -10
Branches 16636 16632 -4
==========================================
- Hits 75191 75170 -21
- Misses 27775 27786 +11
Partials 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Opt-Mucca
left a comment
There was a problem hiding this comment.
@galabovaa only one point (I do think that should be changed though).
Is enabling the sanitizers going to cause test times in general to now increase a lot?
| std::vector<double> submip_start_time; | ||
| std::vector<HighsInt> submip_clock_running; | ||
| std::vector<bool> submip; | ||
| std::vector<char> submip; |
There was a problem hiding this comment.
I'd suggest changing this to uint8_t
We should just run it on PR, but until all is in latest I left it on push 😅 |
std::vector is the one STL container with no element-independence guarantee