Add halo exchanges to ForwardBackward Timestepper - #490
Open
andrewdnolan wants to merge 2 commits into
Open
Conversation
andrewdnolan
commented
Jul 31, 2026
Author
|
16 tasks
|
@hyungyukang, please give this a look when you can. |
hyungyukang
reviewed
Aug 4, 2026
Co-authored-by: Hyun (Hyun-Gyu) Kang <47987430+hyungyukang@users.noreply.github.com>
andrewdnolan
force-pushed
the
omega/forward-backward-halo
branch
from
August 12, 2026 16:02
2e0a7aa to
b879387
Compare
Author
Testing:
Where I needed to apply this diff: diff --git a/components/omega/cime_config/buildnml b/components/omega/cime_config/buildnml
index 9f86189bdb..30817523bc 100755
--- a/components/omega/cime_config/buildnml
+++ b/components/omega/cime_config/buildnml
@@ -275,12 +275,8 @@ def _build_time_integration_config(default_time_integration, case):
# RunDuration is not used in coupled runs
time_integration["RunDuration"] = "none"
- # All meshes use RK4 timestepping (for now)
- time_integration["TimeStepper"] = "RungeKutta4"
-
- if ocn_grid == "oQU240":
- time_integration["TimeStep"] = "0000_00:05:00"
- elif ocn_grid == "EC30to60E2r2":
+ if ocn_grid == "EC30to60E2r2":
+ time_integration["TimeStepper"] = "RungeKutta4"
time_integration["TimeStep"] = "0000_00:01:00"
return time_integrationin order to use Forward-Backward timestepping. As an aside, #494 will make changes to the |
hyungyukang
approved these changes
Aug 12, 2026
hyungyukang
left a comment
There was a problem hiding this comment.
CTests passed on both Frontier GPU and CPU.
The Polaris decomp and restart tests for the baroclinic channel also passed using the Forward-Backward time stepper.
Based on @andrewdnolan 's testing, my own testing, and visual inspection, I am approving this PR. Thanks, @andrewdnolan !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add missing halo exchanges between sub steps for the
ForwardBackwardtime stepper. Without these PEM test usingForwardBackwardtime stepping failed, even after rebasing onto #488 .Fixes #489.
Checklist
Linting
Building
Testing
aurora, oneapi-ifx, mpich
chrysalis, oneapi-ifx, openmpi
frontier, craygnu, mpich
frontier, craygnu-mphipcc, mpich
pm-cpu, gnu, mpich
pm-gpu, gnugpu, mpich
Provide relevant details in a comment to the PR titled
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build