Conversation
maartenba
left a comment
There was a problem hiding this comment.
Looks solid!
Note to self: needs duplication into v8 samples folder for now.
|
Maybe also extend DiscoveryResponseGenerator to add |
I'm setting this via configuration. If CIMD was built into identity server I'd definitely want to make that automatic in the generator. But as a sample I think this is ok. Do you have something in mind to favor the generator? |
No, I was hoping it makes it all the way to identity server as a feature, alongside DCR :) |
|
@bhazen @maartenba - I've made some changes since your reviews, and wondered if you would take a fresh look. Notable is the use of Barry Dorrans' new SSRF protection package, and expansion of the extension points in the cimd policy. |
maartenba
left a comment
There was a problem hiding this comment.
Nothing to add, looks good imo
This adds a sample showing how to implement CIMD in IdentityServer to authenticate MCP clients like VS Code.
Apologies for the large number of files, but most of it is standard IdentityServer and a copy of the weather MCP server.
The interesting dozen or so CIMD-specific files are all in CIMD.IdentityServer/. Everything else is copied from McpDemo with namespace changes.