Skip to content

[STACKED on #957] feat(kms): authorize from finalized Ethereum snapshots - #958

Merged
kvinwang merged 4 commits into
masterfrom
codex/feat-kms-finalized-ethereum-auth
Aug 6, 2026
Merged

[STACKED on #957] feat(kms): authorize from finalized Ethereum snapshots#958
kvinwang merged 4 commits into
masterfrom
codex/feat-kms-finalized-ethereum-auth

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

STACKED PR — merge #957 first.

Problem

Ethereum authorization read the latest chain state, which can be reorganized. A decision based on an unfinalized block could later disappear or change while KMS had already issued access.

Root cause and fix

Evaluate policy against a finalized block/snapshot and bind the decision to that finalized state.

Implementation

The branch records the following focused implementation work:

  • test(kms): cover Ethereum authorization freshness
  • test(kms): define Ethereum finalized snapshots
  • feat(kms): authorize from finalized Ethereum snapshots
  • fix(kms): assert redacted backend diagnostics

Changed paths:

  • dstack/kms/auth-eth-bun/index.test.ts
  • dstack/kms/auth-eth-bun/index.ts

Scope

This PR addresses one logical kms finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

Verification

  • git diff --check origin/codex/fix-kms-node-auth-safety..origin/codex/feat-kms-finalized-ethereum-auth: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/feat-kms-finalized-ethereum-auth branch from 2dd1b31 to 8f07694 Compare August 5, 2026 03:18
@kvinwang
kvinwang force-pushed the codex/feat-kms-finalized-ethereum-auth branch from 8f07694 to d228e05 Compare August 5, 2026 15:42
@kvinwang
kvinwang force-pushed the codex/feat-kms-finalized-ethereum-auth branch from d228e05 to 1c49780 Compare August 6, 2026 01:05
@kvinwang
kvinwang force-pushed the codex/feat-kms-finalized-ethereum-auth branch from 1c49780 to 3fbd8d7 Compare August 6, 2026 01:38
Base automatically changed from codex/fix-kms-node-auth-safety to master August 6, 2026 02:11
@kvinwang
kvinwang force-pushed the codex/feat-kms-finalized-ethereum-auth branch from 3fbd8d7 to 99c9fbb Compare August 6, 2026 02:11
@kvinwang
kvinwang merged commit 1270d5d into master Aug 6, 2026
15 checks passed
kvinwang added a commit that referenced this pull request Aug 6, 2026
[STACKED on #958] feat(kms): emit authorization policy audit events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants