Skip to content

fix(gateway): validate peer synchronization URLs - #932

Merged
kvinwang merged 1 commit into
masterfrom
codex/fix-gateway-peer-sync-urls
Aug 5, 2026
Merged

fix(gateway): validate peer synchronization URLs#932
kvinwang merged 1 commit into
masterfrom
codex/fix-gateway-peer-sync-urls

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

Peer synchronization URLs from persisted/configured gateway state were accepted without restricting scheme, credentials, or malformed host data. Synchronization could target an invalid or unintended endpoint and fail after state was committed.

Root cause and fix

Parse and validate peer URLs at the boundary, allowing only the supported secure form before storing or connecting.

Implementation

The branch records the following focused implementation work:

  • fix(gateway): validate peer synchronization URLs

Changed paths:

  • dstack/gateway/src/kv/mod.rs

Scope

This PR addresses one logical gateway finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and has no parent dependency.

Verification

  • git diff --check origin/master..origin/codex/fix-gateway-peer-sync-urls: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang kvinwang changed the title [STACKED on #915] fix(gateway): validate peer synchronization URLs fix(gateway): validate peer synchronization URLs Aug 4, 2026
@kvinwang
kvinwang force-pushed the codex/fix-gateway-peer-sync-urls branch from ba59091 to 8c47ef1 Compare August 4, 2026 15:25
@kvinwang
kvinwang changed the base branch from codex/fix-gateway-dns-credential-storage to master August 4, 2026 15:25
@kvinwang
kvinwang merged commit bed81df into master Aug 5, 2026
19 checks passed
kvinwang added a commit that referenced this pull request Aug 5, 2026
…er-identity

[STACKED on #932] fix(gateway): accept app-info peer identities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants