fix(mock-attestation): handle PCK collateral errors - #1017
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change is small, localized to one handler, and brings behavior in line with existing error-handling patterns in this file while addressing the Clippy failure.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the mock-attestation HTTP server to avoid unwrap() in the PCCS PCK CRL handler, aligning with the workspace’s Clippy clippy::unwrap_used denial and preventing panics in an HTTP request path.
Changes:
- Handle
tdx.sample_collateral()failure in the PCK CRL route and return HTTP 500 instead of panicking. - Reuse the generated collateral to populate the
SGX-PCK-CRL-Issuer-Chainheader (avoids regenerating collateral / second fallible call).
File summaries
| File | Description |
|---|---|
| dstack/crates/mock-attestation/src/server.rs | Replaces unwrap() in the PCK CRL handler with explicit error handling and collateral reuse for the issuer-chain header. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Rust checksworkflow onmasterfails Clippy because the mock PCCS PCK CRL handler callsunwrap()while the workspace deniesclippy::unwrap_used.The panic is also inappropriate for an HTTP handler because collateral generation can fail.
Change
sample_collateral()failures explicitlyVerification
cargo fmt --manifest-path dstack/Cargo.toml --all -- --checkcargo clippy --manifest-path dstack/Cargo.toml -p mock-attestation -- -D warnings -D clippy::expect_used -D clippy::unwrap_used --allow unused_variablesgit diff --check