fix: video playback state synchronization#960
Open
schembriaiden wants to merge 1 commit intoDonutWare:developfrom
Open
fix: video playback state synchronization#960schembriaiden wants to merge 1 commit intoDonutWare:developfrom
schembriaiden wants to merge 1 commit intoDonutWare:developfrom
Conversation
Collaborator
|
I'm not sure this is the fix for that users problem. The issue might actually be in the way playback is paused or at least how the signal is passed on to flutter. |
120a7d7 to
69173b3
Compare
Contributor
Author
I think this should be the actual fix now, thanks for your feedback. |
69173b3 to
de4df12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request improves the handling of playback state synchronization between the UI and the playback model in the video player feature. The main updates ensure that the playback state is accurately reflected and that the UI stays in sync with the underlying state.
Playback state synchronization improvements:
_setupListenersmethod in_VideoPlayerStateto listen for changes to theplayingstate frommediaPlaybackProviderand update the localplayingvariable accordingly, ensuring the UI remains in sync with the playback state.updatePlaybackPositioninVideoPlayerNotifierto use the newplayingvalue from the event, rather than the previous state, for more accurate state updates.Issue Being Fixed
Resolves #787
Screenshots / Recordings
Tested On
Checklist