Skip to content

fix: video playback state synchronization#960

Open
schembriaiden wants to merge 1 commit intoDonutWare:developfrom
schembriaiden:fix/android-tv-not-pausing
Open

fix: video playback state synchronization#960
schembriaiden wants to merge 1 commit intoDonutWare:developfrom
schembriaiden:fix/android-tv-not-pausing

Conversation

@schembriaiden
Copy link
Copy Markdown
Contributor

@schembriaiden schembriaiden commented Apr 17, 2026

Pull Request Description

This pull request improves the handling of playback state synchronization between the UI and the playback model in the video player feature. The main updates ensure that the playback state is accurately reflected and that the UI stays in sync with the underlying state.

Playback state synchronization improvements:

  • Added a _setupListeners method in _VideoPlayerState to listen for changes to the playing state from mediaPlaybackProvider and update the local playing variable accordingly, ensuring the UI remains in sync with the playback state.
  • Updated the call to updatePlaybackPosition in VideoPlayerNotifier to use the new playing value from the event, rather than the previous state, for more accurate state updates.

Issue Being Fixed

Resolves #787

Screenshots / Recordings

Tested On

  • Android
  • Android TV
  • iOS
  • Linux
  • Windows
  • macOS
  • Web

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

@PartyDonut
Copy link
Copy Markdown
Collaborator

I'm not sure this is the fix for that users problem.
This would only add a small delay to the call itself I believe.

The issue might actually be in the way playback is paused or at least how the signal is passed on to flutter.

@schembriaiden schembriaiden force-pushed the fix/android-tv-not-pausing branch from 120a7d7 to 69173b3 Compare April 18, 2026 19:34
@schembriaiden
Copy link
Copy Markdown
Contributor Author

The issue might actually be in the way playback is paused or at least how the signal is passed on to flutter.

I think this should be the actual fix now, thanks for your feedback.

@schembriaiden schembriaiden force-pushed the fix/android-tv-not-pausing branch from 69173b3 to de4df12 Compare April 18, 2026 20:21
@schembriaiden schembriaiden changed the title fix: ensure Exo Player controls run on the main thread fix: video playback state synchronization Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Playback seems to resume when screensave is active

2 participants