feat(vault): Added 1Password as Secrets provider - #5154
Open
bjerringgaard wants to merge 1 commit into
Open
Conversation
| ReturnType<typeof client.environments.getVariables> | ||
| >; | ||
| try { | ||
| response = await client.environments.getVariables(config.environmentId); |
Contributor
There was a problem hiding this comment.
Unbounded 1Password API request
The 1Password client awaits getVariables without the shared 15-second request bound used by the HTTP-based vault clients. If the 1Password API is slow or unresponsive, vault resolution, connection tests, and secret-name requests remain stalled beyond the expected timeout.
Knowledge Base Used: DNS and Vault Providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Added 1Password as an option for the vault-providers.
Making use of 1password's newer "Environments" feature.
Relying on 1Password's Service Account Authentication
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #1777
closes #1192
Greptile Summary
The PR adds 1Password Environments as an organization-level vault provider using service-account authentication.
Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking request-lifecycle concern around unbounded 1Password SDK calls.
The provider is integrated across schema, migration, masking, UI, and vault dispatch, but its external API path does not explicitly preserve the bounded-request behavior used by the other HTTP-backed vault clients.
Files Needing Attention: packages/server/src/utils/vault/onepassword.ts
Reviews (1): Last reviewed commit: "feat(vault): Added 1Password as Secret p..." | Re-trigger Greptile
Context used: