fix: add sourceType to apiCreateCompose and apiCreateApplication#4710
Open
elijahdev0 wants to merge 1 commit into
Open
fix: add sourceType to apiCreateCompose and apiCreateApplication#4710elijahdev0 wants to merge 1 commit into
elijahdev0 wants to merge 1 commit into
Conversation
apiCreateCompose and apiCreateApplication did not include sourceType in their .pick() schemas, causing every compose/application created via the API to default to 'github' in the DB. Users had to manually update the sourceType after creation.
sourceType is already defined as .optional() in both createSchemas, so this is backward-compatible — callers that don't send it will still get the DB default ('github').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
apiCreateComposeandapiCreateApplicationusecreateSchema.pick({...})but omitsourceTypefrom the pick list. Because the DB column defaults to"github":Every compose/application created via the API gets
sourceType: "github"regardless of intention. Users must manually update it after creation via the compose/application update endpoint.Fix
Add
sourceType: trueto both.pick()schemas:packages/server/src/db/schema/compose.ts—apiCreateComposepackages/server/src/db/schema/application.ts—apiCreateApplicationWhy it's safe
sourceTypeis already defined as.optional()in bothcreateSchemas, so callers that don't send it will still get the DB default ("github"). This is purely additive — no breaking change.Template-based creation (
createComposeByTemplate) and the/compose.updateendpoint are unaffected (they already handlesourceTypecorrectly).Impact
POST /compose.createnow accepts an optionalsourceTypefieldPOST /application.createnow accepts an optionalsourceTypefieldtrpc-openapifrom Zod schemas)