fix: comment toggle shortcut not working in environment variable editors#4403
Open
amit-y11 wants to merge 1 commit into
Open
fix: comment toggle shortcut not working in environment variable editors#4403amit-y11 wants to merge 1 commit into
amit-y11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fix
Cmd+/orCtrl+/comment toggle shortcut not working in environment variable editors (properties language mode).CodeMirror's
toggleCommentcommand requirescommentTokensmetadata (vialanguageData) to know which syntax to use for commenting. Thepropertieslanguage mode from@codemirror/legacy-modesdoes not export this metadata, unlikeyaml,shell, andjsonmodes which all include it. This causedCtrl+/to silently fail in all editors usinglanguage="properties"including environment variable editors, volume content, and more.The fix adds
languageData: { commentTokens: { line: "#" } }to the properties stream parser definition in the sharedCodeEditorcomponent, enabling#line comments viaCtrl+/across all properties-mode editors in the app.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4402
Screenshots (if applicable)