-
Notifications
You must be signed in to change notification settings - Fork 0
feat(hooks): block --no-verify, the one bypass of the four with no rule (v1.41.0) #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@lapc506/make-no-mistakes", | ||
| "version": "1.38.0", | ||
| "version": "1.41.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 P2 (major) — Missing Version Update in README.md. The version manifests (package.json, plugin.json, marketplace.json) are bumped to 1.41.0, but README.md is not updated in this PR (still refers to 1.38.0). This violates the repo's own 'warn-version-readme-changelog-sync' rule/guideline. Please update the README.md version header to 1.41.0 to ensure consistent versioning across all surfaces. [pass 1] |
||
| "description": "The disciplined dev lifecycle — implement issues, review PRs, sync releases, test E2E, manage sessions, stash secrets, and enforce manifest-driven tool-call hooks (no SSH+DB, no manual prod, no minified build, no secret leaks, Slack format). OpenCode + Claude Code plugin.", | ||
| "type": "module", | ||
| "main": "./dist/index.js", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 P2 (major) — False Positive Risk on Commit Messages. The pattern matches ' -n ' or '--no-verify' regardless of whether they are inside a commit message (e.g., git commit -m "feat: support -n in client"). Since 'bypass_marker' is set to null, a developer running a completely valid commit with such a message will be blocked with no way to bypass. Consider either refining the regex to avoid matching inside quoted strings, or introducing a bypass_marker (e.g., 'no-verify-allowed') to let developers unblock themselves in case of false positives.
[pass 1]